Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
42 stars 16 forks source link

Conda is removed from PATH on purpose on Windows [development branch] #321

Open napsternxg opened 9 years ago

napsternxg commented 9 years ago

I use Anaconda python distribution and was trying to install wordseer on a virtualenv however, I was getting this error about pip not being installed. On looking closely at the install.py script I found the following piece of code which was causing the problem

new_path_dirs = []
    path_dirs = os.environ["PATH"].split(":")
    for path_dir in path_dirs:
        if "conda" not in path_dir:
            new_path_dirs.append(path_dir)

    os.environ["PATH"] = ":".join(new_path_dirs)

I don't fully understand the inclusion of this code as it purposely tries to exclude conda from the PATH and also edits the user path which should not be done by any application.

After commenting out this portion of that code my installation worked fine. I can send a pull request which removes this code from the install.py script.

macfarlandian commented 9 years ago

@napsternxg I don't know the provenance of that particular snippet, but in general we've had some issues with the anaconda distribution conflicting with virtualenv before, so I suspect it's got something to do with that.

What versions of Windows and Anaconda are you running? If possible I want to try to recreate this bug and check for some of those known issues.