search

Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
40 stars 16 forks source link

Fixing a info logger statement #329

Closed vijaym123 closed 8 years ago

vijaym123 commented 8 years ago

Hi @macfarlandian,

The logger.info takes in a string argument, so I just added a simple fix to it. Let me know, if you would like to add any additional checks in here. Thanks! :)

macfarlandian commented 8 years ago

@vijaym123 great catch ... looks like it was just silently failing and I never even realized there was missing log output.

The point of logging that sentence was to let you know what sentence the parser failed on to give you a place to start debugging. But now that I'm looking at this code again, it kind of seems like the sentence text ought to just be added to the end of the error message. What do you think?

vijaym123 commented 8 years ago

Yes, you are right. Changed the message from info to error. Thanks for the code review!