search

Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
42 stars 16 forks source link

create API endpoints #35

Closed macfarlandian closed 10 years ago

macfarlandian commented 10 years ago

is any of the ongoing work on the models going to affect my ability to get started on this?

keien commented 10 years ago

I don't think so...most models are stable, though Sets just got nesting added today so maybe we should do more extensive testing for that. But there's also bound to be other models and fields for existing models that are probably missing in the current implementation that we'll need to add as you write the controllers.

abendebury commented 10 years ago

Yeah, most of the models functionality is already nailed down.

macfarlandian commented 10 years ago

how are we handling the "instances" from the PHP application? do i need to pass that to the models as an argument or is every "instance" just going to be a self-contained Flask app?

macfarlandian commented 10 years ago

if you look in sets.py in the setup-api-controllers branch, that's the prototype for how I'm planning to set these up. let me know if you think it makes sense.

keien commented 10 years ago

I think this one's for David to answer...hopefully he'll get back to you soon.

abendebury commented 10 years ago

Instances... I think Keien and I discussed this recently. If I remember correctly, we decided that our Projects were a good replacement.

However, the key difference is that in the PHP, the instances all had their own database so the backend always operated on the right project. If I understand it, the python backend needs to know which Project is being worked on to return proper results, so I guess you would have to pass the current project ID as a parameter... maybe even for every query.

macfarlandian commented 10 years ago

roger

keien commented 10 years ago

Does this need to be open anymore?

macfarlandian commented 10 years ago

no, probably not ... not really a proper issue

On Tue, Aug 12, 2014 at 12:06 AM, Keien Ohta notifications@github.com wrote:

Does this need to be open anymore?

— Reply to this email directly or view it on GitHub https://github.com/Wordseer/wordseer_flask/issues/35#issuecomment-51880435 .