Workable / orka

8 stars 2 forks source link

Fix Datadog traces for health #234

Open klouvas opened 3 years ago

klouvas commented 3 years ago

Based on the configuration defined in orka for datadog metrics there should NOT be any traces for health endpoint in datadog. Based on the career pages datadog dashboard we see that some requests are traced.

nikostoulas commented 3 years ago

It seems that we have a typo in the configuration as seen here: https://docs.datadoghq.com/tracing/setup_overview/custom_instrumentation/nodejs?tab=locally

Datadog expects blocklist not blacklist.

nikostoulas commented 3 years ago

Care to fix this @klouvas ?

klouvas commented 3 years ago

i checked about that and in version dd-trace@0.30.5 that is used in orka the blacklist option is deprecated but it's not removed. https://github.com/DataDog/dd-trace-js/blob/v0.30.5/packages/dd-trace/src/plugins/util/urlfilter.js#L14

nikostoulas commented 3 years ago

That's weird then. Possibly needs some debugging to figure out what is happening.