search

Workable / orka

8 stars 2 forks source link

Add changelog notes for migrating to Orka 3.* #309

Closed kkyriakidis closed 2 years ago

kkyriakidis commented 2 years ago

The mongoDB Node.js driver derives from the mongoose version. Unless specific stated. There can be incompatibilities with libraries using the driver. In our case in assessments we had an issue with ts-mongoose for example.

Also we had breaking changes noted to the mongoose migration guide Types.ObjectId is now a class, which means you can no longer omit new when creating a new ObjectId using new mongoose.Types.ObjectId(). Currently, you can still omit new in JavaScript, but you must put new in TypeScript. Do you think I should specific add this to the orka changelog? @nikostoulas

nikostoulas commented 2 years ago

The mongoDB Node.js driver derives from the mongoose version. Unless specific stated. There can be incompatibilities with libraries using the driver. In our case in assessments we had an issue with ts-mongoose for example.

Also we had breaking changes noted to the mongoose migration guide Types.ObjectId is now a class, which means you can no longer omit new when creating a new ObjectId using new mongoose.Types.ObjectId(). Currently, you can still omit new in JavaScript, but you must put new in TypeScript. Do you think I should specific add this to the orka changelog? @nikostoulas

If you think they are common sure. If not then link to the docs is ok.