search

Workable / orka

8 stars 2 forks source link

Migrate KafkaJS to ^2.0.0 #384

Closed kalyvasio closed 4 months ago

kalyvasio commented 5 months ago

Bumps KafkaJS to 2.0.0

It contains two major changes that affect us

Manage topics through admin client

KafkaJS contains some non-backwards compatible options in regards to managing topics via the admin client We have changed the implementation to support the new array handling of topic and offsets

Default partitioner

Another change is the update of the DefaultPartitioner By default the JavaCompatiblePartitioner is used but if not explicitly set it will log a warning We are setting it by default (if not already set) here If for some reason someone needs to use the old partitioner (LegacyPartitioner), it can be set through the .withKafkaOptions() e.g .withKafka({ createPartitioner: Partitioners.LegacyPartitioner })

nikostoulas commented 5 months ago

@kalyvasio Can we please also add the breaking changes here: https://workable.github.io/orka/#migrating-from-orka--3x-to-4x?

nikostoulas commented 5 months ago

@kalyvasio Can we please also add the breaking changes here: https://workable.github.io/orka/#migrating-from-orka--3x-to-4x?

FYI here https://github.com/Workable/orka/blob/915d882a915887b1cad7ed6a9d1a0e8260f9522e/docs/index.md?plain=1#L77 is the place to add the changes

kalyvasio commented 5 months ago

@kalyvasio Can we please also add the breaking changes here: https://workable.github.io/orka/#migrating-from-orka--3x-to-4x?

FYI here

https://github.com/Workable/orka/blob/915d882a915887b1cad7ed6a9d1a0e8260f9522e/docs/index.md?plain=1#L77

is the place to add the changes

I have updated the docs and I have added the usage for the Default Partitioner in the Kafka md in this commit Please take a look and tell me if you want something different