search

Workday / canvas-kit

Development kits to implement UI following the Workday Canvas Design System (https://canvas.workday.com/). See our Component Storybook -
https://workday.github.io/canvas-kit/
Apache License 2.0
297 stars 219 forks source link

chore: Updated unique id generation for classnames #2913

Closed josh-bagwell closed 1 week ago

josh-bagwell commented 3 weeks ago

Summary

Fixes: #2912

This is to update the hash generation for classnames in non-compat mode.

Release Category

Components

Where Should the Reviewer Start?

/modules/styling/lib/cs.ts /modules/styling-transform/lib/utils/createStyleObjectNode.ts

cypress[bot] commented 3 weeks ago

Workday/canvas-kit    Run #7763

Run Properties:  status check passed Passed #7763  •  git commit a78fc9c8d7 ℹ️: Merge e31eaf06d037c55b7382a8e5bcaa431287d20760 into 4058beef767f8452c4729dc916c1...
Project Workday/canvas-kit
Branch Review styles-unique-id-update-24-09
Run status status check passed Passed #7763
Run duration 03m 27s
Commit git commit a78fc9c8d7 ℹ️: Merge e31eaf06d037c55b7382a8e5bcaa431287d20760 into 4058beef767f8452c4729dc916c1...
Committer Josh
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 15
Tests that did not run due to a developer annotating a test with .skip  Pending 16
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 854
View all changes introduced in this branch ↗︎
UI Coverage  21.05%
  Untested elements 1843  
  Tested elements 489  
Accessibility  99.23%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 229