Workday / canvas-kit

Development kits to implement UI following the Workday Canvas Design System (https://canvas.workday.com/). See our Component Storybook -
https://workday.github.io/canvas-kit/
Apache License 2.0
302 stars 221 forks source link

feat: Refactor Hyperlink and ExternalHyperlink #3050

Open alanbsmith opened 2 weeks ago

alanbsmith commented 2 weeks ago

Summary

Fixes: #1234

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

For the Reviewer

Where Should the Reviewer Start?

Areas for Feedback? (optional)

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

cypress[bot] commented 2 weeks ago

Workday/canvas-kit    Run #8051

Run Properties:  status check passed Passed #8051  •  git commit 6a0761b138 ℹ️: Merge 2b933a295958facab4f7ff25c207731304b1ab9a into cc00a3c53acab8337147f2e305b0...
Project Workday/canvas-kit
Branch Review refactor-hyperlink
Run status status check passed Passed #8051
Run duration 03m 57s
Commit git commit 6a0761b138 ℹ️: Merge 2b933a295958facab4f7ff25c207731304b1ab9a into cc00a3c53acab8337147f2e305b0...
Committer Alan B Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 30
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1093
View all changes introduced in this branch ↗︎
UI Coverage  21.74%
  Untested elements 1643  
  Tested elements 454  
Accessibility  99.18%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 180