CanvasProvider's bdo tag is not recognized in IE11

miguelc1221 commented 4 years ago

🐛 Bug Report

When using the <CanvasProvider />, IE11 doesn't recognize the <bdo> tag and so IE in this case doesn't add a display property, therefore there is a blank space above our app (you can see how the right border on sidebar doesn't reach the top). Explicitly Adding display: 'block' fixes this issue.

To Reproduce

Wrap your app component in <CanvasProvider />
Render a <h1>Hi</hi> and remove any top margins/padding
You can now see that the Hi text still has a space above

Expected Behavior

There should be no space above our app when using the <CanvasProvider /> in IE11.

Browser (if applicable)

IE11

lychyi commented 4 years ago

Thanks for reporting, @miguelc1221

Do you have a code sandbox for this or a proposed fix?

miguelc1221 commented 4 years ago

@lychyi i don't have a sandbox, but i believe @NicholasBoll confirmed this. The fix would be to add a display: 'block' to the bdo tag

miguelc1221 commented 4 years ago

i can open a quick pr when i have some time.

anicholls commented 3 years ago

Closed by #868

Workday / canvas-kit