search

Workflomics / workflomics-frontend

Front end of the Workflomics - workflow benchmarking platform.
https://workflomics.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
3 stars 2 forks source link

Benchmarking - unnecessary line break #66

Open vedran-kasalica opened 6 months ago

vedran-kasalica commented 6 months ago

When visualising the runtime benchmarks if the font is large enough there is a linebreak on the status of failed workflows, even though there is plenty of horizontal space to expand the table, see:

Screenshot 2024-05-06 at 19 48 00

Although a bit less important, it would be nice if the header of the column would only break between "STATUS" and the first parenthesis when needed (see https://github.com/Workflomics/workflomics-frontend/issues/66#issuecomment-2096674130).

magnuspalmblad commented 6 months ago

The benchmark line break is the major offender here, but if you or @kretep are looking into this, maybe also look into the column headers. The first one could use a break between "STATUS" and the first parenthesis. "PROTEINS IDENTIFIED" could be changed into "PROTEINS" and "GO-TERMS IDENTIFIED" into "GO-TERMS" to keep all column headers in two rows?

vedran-kasalica commented 6 months ago

I was thinking about the same, STATUS does break in a weird way. We will look into it, but it might not be so trivial considering that the table (including the headers) is parsed from a json file. I just updated the 2 column names as you suggested.

vedran-kasalica commented 6 months ago

I just looked into it and they are treated as 2 separate strings, one is the description (e.g., “status”) and the other one is units (e.g., “✓ or ✗”), so enforcing linebreak only in between the 2 should not be difficult.

magnuspalmblad commented 6 months ago

This would be worth a try - it may give the table a more consistent look.