[FEATURE] Visually differentiating between "UNKNOWN" and zero/not OSI-approved license, etc.

Workflomics / workflomics-frontend

Front end of the Workflomics - workflow benchmarking platform.

https://workflomics.readthedocs.io/en/latest/?badge=latest

Apache License 2.0

3 stars 2 forks source link

[FEATURE] Visually differentiating between "UNKNOWN" and zero/not OSI-approved license, etc. #73

Closed magnuspalmblad closed 1 month ago

magnuspalmblad commented 1 month ago

Feature Description

In the benchmark view, both "UNKNOWN" licenses/number of citations, and non-OSI-approved licenses/zero citations are mapped to white.

Motivation

It would be nice to be able to be able to visually distinguish between these NAs and zeroes.

Proposed Solution

Map NAs (unknowns) to a diagonal black line through the small box (white background) and continue to map non-OSI-approved license/zero citations to white.

Alternatives Considered

No alternatives have been considered.

Additional Context

vedran-kasalica commented 1 month ago

That is a good point. The current framework supports colors, but we can look into including graphical elements such as lines. I tried using red to annotate a closed license and white to indicate a missing license as an alternative, but I didn't keep it as I was not sure whether we could be certain that one is always "worse" than the other.

vedran-kasalica commented 1 month ago

I looked into it, and it's not hard to implement a diagonal line to it. Does this look like something you had in mind? If we decide to use it, we can have all elements that are unknown (number of citations for example) marked the same way