search

WorkflowConversion / CTDConverter

Series of python scripts to convert CTD files into other formats such as Galaxy, CWL
MIT License
5 stars 8 forks source link

restructure python package #58

Closed bernt-matthias closed 3 years ago

bernt-matthias commented 3 years ago

If one pip installs this project it creates: common, galaxy, and cwl directly in the python dictribution. Would be nice to have all those modules in one folder, e.g. ctdconverter/common.

mr-c commented 3 years ago

I started this already at https://github.com/WorkflowConversion/CTDConverter/pull/56/commits/4ab09edb0fd0020b4360d0aba16abba95efd260b ; but feel free to pull that out and finish it ; the galaxy tests are giving me difficulties

bernt-matthias commented 3 years ago

Wonderful. I can have a look on the Galaxy tests.

mr-c commented 3 years ago

@bernt-matthias I redid that commit and pushed a branch to https://github.com/WorkflowConversion/CTDConverter/tree/layout_package ; we can collaborate there

bernt-matthias commented 3 years ago

OK. Could you open a PR for this branch? Then its easier to communicate.

I think it would also be good if we would have a task list such that we can work together without creating to many conflicts.

mr-c commented 3 years ago

https://github.com/WorkflowConversion/CTDConverter/pull/59

I think it would also be good if we would have a task list such that we can work together without creating to many conflicts.

Agreed!

mr-c commented 3 years ago

Fixed in #59