WorkingRobot / Craftimizer

The best FFXIV crafting solver via hardware accelerated Genetic MCTS.
MIT License
16 stars 5 forks source link

Synthesis Helper not considering quality dependent actions #11

Closed zocke1r closed 8 months ago

zocke1r commented 8 months ago

I noticed that the Synthesis helper does take the current quality into account when calculating its solution. Sadly though it doesn't seem to be able to recommend quality dependent actions for the current step, causing suboptimal solutions in certain situations.

WorkingRobot commented 8 months ago

Could you elaborate more? That's exactly what it was designed to do and you can see it in its solution. Could you provide any reproducible steps or evidence?

zocke1r commented 8 months ago

Here a screenshot of the situation i mean. image It recommends using Standard touch even though Precise touch is available, which would give more quality and quality of the current solution is not already maxed, so Precise touch would lead to a better result.

WorkingRobot commented 8 months ago

You have waste not active. I can see in the screenshot that even the calculator says you can't prudent touch.

zocke1r commented 8 months ago

Yip that was a typo meant precise touch, got distracted by the prudent touch not being usable, but as you can see in the screenshot the 150% efficiency action is available but the 125% action is being recommended

WorkingRobot commented 8 months ago

The solver doesn't look for actions that rely on conditions being active (i.e. tricks of the trade, precise touch/synthesis, etc) It can and does simulate conditions, but it doesn't recommend those actions yet; this is related to #7.