WorkingRobot / Craftimizer

The best FFXIV crafting solver via hardware accelerated Genetic MCTS.
MIT License
15 stars 5 forks source link

Crafter's delineation ability crash #14

Closed anndrox closed 3 months ago

anndrox commented 4 months ago

Was working on the 5th tier splendorous tools for Connoisseur's Crab Cakes and I decided to throw a crafter's delineation ability into the mix. Since then, the game has been crashing when processing the algorithm. I have tried removing the plugin and deleting the folder inside Dalmund plugin folder and not using the delineation skill again but it still occurs when crafting. If there are logs I can provide, please let me know and I will provide.

anndrox commented 4 months ago

dalamud.old.log Adding log file

anndrox commented 4 months ago

Reinstalled Dalmund fresh with only craftimizer with fresh profile data /My Games/FINAL FANTASY XIV - A Realm Reborn/ with the same results as well.

anndrox commented 4 months ago

It doesn't have anything to do with the delineation abilities. I started the next tier but it does not always crash. I got through 7 complete cycles and it crashed. I changed the Max Core Count from 20 to 18 (I have 16 i7-13700k) to 14 to see if it makes a difference. Here is a video of the hard-stop https://drive.lanlab.one/d/s/yJJG2A0F56IzNM0uzQMRac7beggQY8FR/SjSqmkc8UDzmZoX9QO7j-txiy3f6fX2K-AbPg-EuVVAs

anndrox commented 4 months ago

Same results with it changed to 14. Got through 4 cycles and then crashed.

WorkingRobot commented 4 months ago

Does this happen only with adding specialist actions into the pool? Does the game crash instantly to the desktop, or is there some sort of error popup that appears as well?

anndrox commented 4 months ago

I have not added the abilities into the pool, it was done manually. It crashes immediately to the desktop.

anndrox commented 4 months ago

Sorry, I was not clear. It happens even without throwing the delineation abilities.

WorkingRobot commented 4 months ago

Hmm, I've tried reproducing this issue for the past few weeks, but I'm still not 100% sure how this happens. Could you send a screenshot of your synthesis helper settings, your character stats window, the item you're crafting, and any food you're using? I'd like to see if I can precisely copy your settings. (A video recording would be appreciated too, if you can manage)

anndrox commented 4 months ago

Can do. image All gear is melded fully except main hand Food: Jhinga Curry (HQ) Pot: Cunning Craftman's Draught (HQ) Crafting ite,m: Connoisseur's Crab Cakes and Connoisseur's Chili Crab both expert recipes Settings: image image image image Video: https://drive.lanlab.one/d/s/yJJG2A0F56IzNM0uzQMRac7beggQY8FR/SjSqmkc8UDzmZoX9QO7j-txiy3f6fX2K-AbPg-EuVVAs If you need me to use another host, let me know. I can also reproduce again if needed. It seems like when it working on a difficult itteration, it freaks out and hard-stops the game. Windows event log does not give much detail. image Also running Windows 11 22H2 build 22621.3447

anndrox commented 4 months ago

Also, thank you for this brilliant addon!

WorkingRobot commented 4 months ago

Thanks for the event viewer btw :) It looks like a stack overflow. I attempted a fix for that recently, but it looks like it didn't work for everyone.

WorkingRobot commented 4 months ago

If possible, could you find a .dmp file associated with the crash and send it over? It should be somewhere in a ffxiv or dalamud adjacent folder (You might not want to send it publicly here since it can contain sensitive info, so you can send it to me on discord @ camora.)

Lanodias commented 4 months ago

Hello. I wonder if this is the same problem as I have. My game crashes almost every time I attempt to do any expert level craft (Island sanctuary mats recently). I'm not using delineations however.

theaaronturner commented 3 months ago

I'm seeing the same exact crashing issue, same settings, and application error in Event Viewer. I've been hunting around trying to find any logs or dumps within FFXIV or Dalamud but not having any luck finding anything due to the nature of the crash kicking immediately out of the game and to the desktop. Any guidance on where to look for logs, or enabling of debug logging within the plugin maybe? Grasping at straws for how to help but as anndrox mentioned, very thankful for your work on this awesome plugin!

WorkingRobot commented 3 months ago

Yep, unfortunately this is a stack overflow issue (and apparently .NET ignored my last fix). Hopefully I'll remember to push a hotfix out today that'll fix things.

WorkingRobot commented 3 months ago

2.4.1.0 is now available for everyone to download. Please let me know if the update fixes the crashes. If not, send me the .dmp file and event viewer info to me on discord (details above)

theaaronturner commented 3 months ago

I've run through 15 expert crafts this morning without issue so things are definitely looking better. I've got quite a few more crafts to run through this afternoon that could serve as a "stress test" to be extra sure, but things look good so far. Thank you!

theaaronturner commented 3 months ago

I believe I've put the plugin through its paces since the most recent update and haven't had a single crash! Happy to say I believe the issue is resolved for me. Thank you!!

WorkingRobot commented 3 months ago

Sounds good, I'll close this issue :)