Workiva / dart_dev

Centralized tooling for Dart projects. Consistent interface across projects. Easily configurable.
https://pub.dartlang.org/packages/dart_dev
Apache License 2.0
74 stars 40 forks source link

Make run return nonnullable FutureOr<int> #406

Closed robbecker-wf closed 1 year ago

robbecker-wf commented 1 year ago

When migrating to null safety we missed making the run method return a non nullable FutureOr ... and that is causing weird casts and slight type mismatches in other tools. This fixes that since the exit code is either zero pass and non-zero for fail but should never be null.

aviary2-wf commented 1 year ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

robbecker-wf commented 1 year ago

Closing in favor of a non-breaking change solution here https://github.com/Workiva/dart_dev/pull/407