search

Workiva / dart_to_js_script_rewriter

A pub transformer that Rewrites Dart script tags to JavaScript script tags, eliminating 404s and speeding up initial loads. Use when building for deployment.
BSD 3-Clause "New" or "Revised" License
21 stars 20 forks source link

Query strings in script urls aren't handled well #13

Closed greglittlefield-wf closed 9 years ago

greglittlefield-wf commented 9 years ago

.js is added to the end of script URLs when they are rewritten, even when the URLs contain query strings.

For example:

Input:

<script type="application/dart" src="entrypoint.dart?cache_busting_query"></script>

Expected output:

<script src="entrypoint.dart.js?cache_busting_query"></script>

Actual output:

<script src="entrypoint.dart?cache_busting_query.js"></script>
sethladd commented 9 years ago

Thanks for the report! PR's definitely welcome.

in fact, if yall are using this, I can transfer this repo to you.

sethladd commented 9 years ago

I'd like to publish a 1.0 version with this fix. Interested in sending over a patch?

greglittlefield-wf commented 9 years ago

Yup, I'll submit one today!

greglittlefield-wf commented 9 years ago

Also, we're definitely open to transferring the repo to the https://github.com/Workiva organization. Would you want to be kept as an "owner"?

sethladd commented 9 years ago

Also, we're definitely open to transferring the repo to the https://github.com/Workiva organization.

Cool! Very nice to see it land in good hands :)

Would you want to be kept as an "owner"?

No need, but appreciate the offer!