search

Workiva / dart_to_js_script_rewriter

A pub transformer that Rewrites Dart script tags to JavaScript script tags, eliminating 404s and speeding up initial loads. Use when building for deployment.
BSD 3-Clause "New" or "Revised" License
21 stars 20 forks source link

CP-1336 kasperpeulen: make sure that transformer only touches file that need to be rewritten #29

Closed evanweible-wf closed 8 years ago

evanweible-wf commented 8 years ago

Copy of #27, but rebased against the latest master.

@kasperpeulen looks like I didn't commit the merge quite right so #27 still shows conflicts. I've rebased your branch against the latest master here in this PR.

This should work now @trentgrover-wf @maxwellpeterson-wf @jayudey-wf

kasperpeulen commented 8 years ago

LGTM

Thanks for the effort!

trentgrover-wf commented 8 years ago

got some dart_dev failures...

codecov-io commented 8 years ago

Current coverage is 96.42%

Merging #29 into master will decrease coverage by -3.58% as of b0e232e

@@            master     #29   diff @@
======================================
  Files            1       1       
  Stmts           21      28     +7
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             21      27     +6
  Partial          0       0       
- Missed           0       1     +1

Review entire Coverage Diff as of b0e232e

Powered by Codecov. Updated on successful CI builds.

evanweible-wf commented 8 years ago

@trentgrover-wf fixed

trentgrover-wf commented 8 years ago

+1

maxwellpeterson-wf commented 8 years ago

+1

maxwellpeterson-wf commented 8 years ago

@jayudey-wf ready for merge

jayudey-wf commented 8 years ago

QA Resource Approval: +10

Merging into master.