search

Workiva / dart_to_js_script_rewriter

A pub transformer that Rewrites Dart script tags to JavaScript script tags, eliminating 404s and speeding up initial loads. Use when building for deployment.
BSD 3-Clause "New" or "Revised" License
21 stars 20 forks source link

HY-4965 Turn on strong mode and 2 lint rules #44

Closed robbecker-wf closed 7 years ago

robbecker-wf commented 7 years ago

This turns on strong mode and adds 2 lint rules to make sure streams are closed.

aviary-wf commented 7 years ago

Raven

Number of Findings: 0

codecov-io commented 7 years ago

Codecov Report

Merging #44 into master will decrease coverage by 3.57%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   96.42%   92.85%   -3.58%     
==========================================
  Files           1        1              
  Lines          28       28              
==========================================
- Hits           27       26       -1     
- Misses          1        2       +1
Impacted Files Coverage Δ
lib/dart_to_js_script_rewriter.dart 92.85% <0%> (-3.58%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6bfec8...e2f18f9. Read the comment docs.

smaifullerton-wk commented 7 years ago

+1

maxwellpeterson-wf commented 7 years ago

+10

maxwellpeterson-wf commented 7 years ago

QA +1

@Workiva/release-management-pp