ci-push-wf commented 6 years ago

Overview

In order to improve build isolation, reduce costs, reduce support burden, remove black magic, and improve local consistency, we are migrating away from smithy.yaml and existing Smithy infrastructure to Dockerfile builds supported by off the shelf AWS resources.

Reviewing and merging this PR is the first step in that process; this PR simply copies the contents of your smithy.yaml into a more explicit Dockerfile. In order to begin running Dockerfile builds you will need to enable Dockerfile builds from your repo configuration page in Smithy. Once you have enabled Dockerfile builds for your repo, rebuilding the PR build in smithy will trigger the newly enabled Dockefile build.

Expectations

With only a couple of exceptions the behavior of this new Dockerfile should match the existing behavior in your smithy.yaml Therefore, our expectations are for you to merge this PR as soon as possible. If for any reason you discover a problem post merge, you can disable the new builds and re-enable smithy.yaml builds in your repo configuration page in Smithy

Support/Questions

The migration to Dockerfile builds is our top priority, so please reach out to us if you have any questions, comments, or concerns during this process. Non-urgent questions should go into Confluence Questions and urgent support can be requested in the Support: Build Tools Hipchat Room

More Info

Information about the migration to dockerfile can be found here A user guide for Dockerfile builds can be found here

@jayudey-wf

aviary-wf commented 6 years ago

Module Findings

No security relevant content detected. Please review for security relevance and request security review as needed.

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files           1        1           
  Lines          27       27           
=======================================
  Hits           26       26           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f57702...1165419. Read the comment docs.

jayudey-wf commented 6 years ago

QA +1

[x] Testing instruction
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- passing CI in new build system
[ ] Security review (if required)
[ ] Unit tests created/updated (n/a)
[x] All unit tests pass
[x] Rosie has run and reports properly the release the ticket will be included in

Merging into master.