Validate less imports - Githubissues

Anrock commented 4 years ago

Motivation

Take imports from .less file into account to produce more accurate dependency analysis

Read and analyze .less files for imports. Basically same as scss but different file extension and regex.

Support .less files analysis

Please review: @Workviva/app-frameworks

[ ] Tests were updated and provide good coverage of the changeset and other affected code
[ ] Manual testing was performed if needed
[ ] Anything falling under manual testing criteria [outlined in CONTRIBUTING.md][contributing-manual-testing]

While we perform many automated checks before auto-merging, some manual checks are needed:

[ ] A Client Platform member has reviewed these changes
[ ] There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
[ ] For release PRs - Version metadata in Rosie comment is correct

aviary3-wk commented 4 years ago

No security relevant content was detected by automated scans.

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Anrock commented 4 years ago

Mentioning @Workviva/app-frameworks didn't work and I can't edit list of reviewers. So I hope somebody will find it as it is ¯_(ツ)_/¯

Anrock commented 4 years ago

@evanweible-wf thank you for suggestions. Everything is fixed and tests for "package://"-cases added.

evanweible-wf commented 4 years ago

@Workiva/release-management-p