Workiva / dependency_validator

A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.
Other
59 stars 18 forks source link

Upgrade json_serializable version to permit analyzer 2.0 usage #75

Closed alanknight-wk closed 3 years ago

alanknight-wk commented 3 years ago

Motivation

By upgrading the json_serializable requirement to 5.0.0, we can support analyzer 2.0

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

aviary3-wk commented 3 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

coreysprague commented 3 years ago

Any update on this? Would love to see this get merged and published. It's the one dependency we have that is holding back a slew of other transitive dependencies (they've all since switched to analyzer 2.*)

alanknight-wk commented 3 years ago

It's complicated. Like, 7 intermediate milestones complicated. https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades

This should probably just get closed for the moment.