Workiva / dependency_validator

A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.
Other
56 stars 18 forks source link

Exit with usage code when incorrect args are used #78

Closed corwinsheahan-wf closed 2 years ago

corwinsheahan-wf commented 2 years ago

Motivation

When non-recognized args are used, we print the help message, but still exit with a 0 exit code. This can cause false positives in CI if legacy command line args are used.

Changes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

aviary-wf commented 2 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

evanweible-wf commented 2 years ago

@corwinsheahan-wf could you add a changelog entry and run formatter on dart 2.14.4?

corwinsheahan-wf commented 2 years ago

@evanweible-wf Updated.

evanweible-wf commented 2 years ago

QA +1

@Workiva/release-management-pp