Workiva / dependency_validator

A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.
Other
58 stars 18 forks source link

2.0.2 return non zero for bad usage #79

Closed corwinsheahan-wf closed 2 years ago

corwinsheahan-wf commented 2 years ago

Motivation

Back patch of this PR to the 2.x release line.

Changes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

aviary3-wk commented 2 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

corwinsheahan-wf commented 2 years ago

@evanweible-wf Done

evanweible-wf commented 2 years ago

Just noticed that the GitHub CI checks aren't running because we hadn't switched over from Travis CI on v2 yet. Tried running the tests locally, but I'm seeing some failures.. looking into it

evanweible-wf commented 2 years ago

QA +1

@Workiva/release-management-p