Workiva / dependency_validator

A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.
Other
56 stars 18 forks source link

FW-167 Only run skynet on releases #91

Closed wesleybalvanz-wf closed 2 years ago

wesleybalvanz-wf commented 2 years ago

Motivation

Currently the skynet config is running on pull requests as well as releases which is causing us to hit the github api rate limit, we don't really need to have the skynet config running on pull requests because it's just needed for release pipelines.

Changes

Add a run config to skynet that limits running to just releases and if there are changes to the skynet.yaml

Release Notes

Run skynet only on releases

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

aviary3-wk commented 2 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

autobot-wk commented 2 years ago

Skynet test results failed initially for this build but were approved by evan.weible https://wf-skynet-hrd.appspot.com/apps/test/smithy/3715176/2 Approval message: Rate limit

charliekump-wf commented 2 years ago

@Workiva/release-management-p ready for merge.

evanweible-wf commented 2 years ago

@Workiva/release-management-p