Improve handling of exit codes

evanweible-wf commented 9 months ago

Now properly forwards the exit code of the subprocess
Exits with 126 if the target command is found, but cannot be executed
Exits with 127 if the target command is not found

These exit codes align with how other similar proxy tools behave:

$ sh -c 'notfound'; echo $?
sh: notfound: command not found
127
$ env notfound; echo $?
env: notfound: No such file or directory
127
$ env /dev/null; echo $?
env: /dev/null: Permission denied
126

Thanks for the help @brettkail-wk!

rmconsole-wf commented 9 months ago

Merge Requirements Unmet :x:

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

:warning: Build successful :x: Release notes requirement met (No tickets associated with this pull request. _Rosie is enforcing release notes requirements because the repo is believed to be customer facing. If this repo is not customer facing, update the value of is_customerfacing in the Rosie Control Panel) - click here to skip this check :x: Dependency Scan Clean (smithy has not started)

General Information

Ticket(s): None found in title Code Review(s): https://github.com/Workiva/dpx/pull/2

Reviewers: brettkail-wk, matthewnitschke-wk, evanweible-wf

Additional Information

Watchlist Notifications: None

    When this pull is merged I will add it to the following release:
    Version: dpx 0.1.0
    Release Ticket(s): None

Note: This is a shortened report. Click here to view Rosie's full evaluation. Last updated on Friday, January 12 11:21 AM CST

aviary-wf commented 9 months ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf commented 9 months ago

QA +1 CI passes

evanweible-wf commented 9 months ago

@Workiva/release-management-p

rmconsole-wf commented 9 months ago

@evanweible-wf I will not merge this because:

'Dependency Scan Clean' is False
'Release notes requirement met' is False
dependencies not scanned

Workiva / dpx