Remove transactor groups env var to fix issue with other catalog configs. - Githubissues

Workiva / eva

A distributed database-system implementing an entity-attribute-value data-model that is time-aware, accumulative, and atomically consistent

Other

565 stars 25 forks source link

Remove transactor groups env var to fix issue with other catalog configs. #108

Closed erikpetersen-wf closed 5 years ago

erikpetersen-wf commented 5 years ago

Description of Changes

Explicitly setting EVA_TRANSACTOR_GROUPS breaks configs which don't contain the value set. For example, https://github.com/Workiva/eva-catalog/blob/master/workivabuild/local-catalog-config.edn, does not set any explicit transactor groups, which causes the transactor to not startup when it is stood up, for example, by the eva-client-service.

Proposed Testing Steps (If Applicable)

Commented out the line when running make run-docker in the client service and everything worked fine.

Relevant Issues (If Applicable)

We shouldn't really maintain multiple config files. We should seek to deprecate/remove the catalog config contained within eva, and opt to use the config contained in the catalog solely.

Maintainer Notifications

@erikpetersen-wf

aviary2-wf commented 5 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

erikpetersen-wf commented 5 years ago

@Workiva/release-management-pp