search

Workiva / eva

A distributed database-system implementing an entity-attribute-value data-model that is time-aware, accumulative, and atomically consistent
Other
565 stars 25 forks source link

Change `sequential?` check to work for java lists as well in eva.v2.database.core #74

Open tylerwilding-wk opened 5 years ago

tylerwilding-wk commented 5 years ago

https://github.com/Workiva/eva/blob/e6196d5e2a215e69dc6dce0651867067ba677cba/core/src/eva/v2/database/core.clj#L447

This check to ensure that the collection that is passed in is ordered does not work for a java List. List or ArrayList do not implement sequential which forces a user to use PersistantVector.create(...) in order to pass a collection into eva. This is not an intentional requirement and should be fixed.