There is a subclass of exceptions that the with-retries macro is setup to ignore. I believe this was originally to bypass non-transient exceptions when doing things like passing a bad value to the indexes for comparison, but don't recall exactly.
The original reason this behavior was desirable needs to be rediscovered and documented, and the with-retries macro should not be responsible for handling this failure case. A good replacement would be to modify the retries macro to either accept a set of white-listed transient or black-listed non-transient set of exceptions to retry with.
There is a subclass of exceptions that the
with-retriesmacro is setup to ignore. I believe this was originally to bypass non-transient exceptions when doing things like passing a bad value to the indexes for comparison, but don't recall exactly.https://github.com/Workiva/eva/blob/e6196d5e2a215e69dc6dce0651867067ba677cba/core/src/eva/utils.clj#L262
The original reason this behavior was desirable needs to be rediscovered and documented, and the
with-retriesmacro should not be responsible for handling this failure case. A good replacement would be to modify the retries macro to either accept a set of white-listed transient or black-listed non-transient set of exceptions to retry with.