RM-24272 Fix that read-only snapshots shared state with original.

Workiva / go-datastructures

A collection of useful, performant, and threadsafe Go datastructures.

Apache License 2.0

7.63k stars 833 forks source link

Closed fasaxc closed 6 years ago

fasaxc commented 6 years ago

Share logic between Snapshot() and ReadOnlySnapshot() to create the snapshot.
For read-only snapshots, use the old root rather than the new-generation's copy.
Add dedicated test for this case.

Fixes #180

aviary-wf commented 6 years ago

Number of Findings: 0

tylertreat commented 6 years ago

lgtm

brianshannan-wf commented 6 years ago