Workiva / go-datastructures

A collection of useful, performant, and threadsafe Go datastructures.
Apache License 2.0
7.66k stars 834 forks source link

btree: remove dependency on github.com/satori/go.uuid #192

Closed rsc closed 6 years ago

rsc commented 6 years ago

The only call was uuid.NewV4().Bytes(), which really means "get me 16 random bytes".

uuid.NewV4 changed at some point to return an error in addition to the UUID, which made this code no longer compile.

There's no need to depend on a uuid package to get 16 random bytes. Do what the old package did, namely read from crypto/rand.Reader and expect it to succeed (or else panic), but without the dependency.

Fixes #187. Fixes #188.

aviary2-wf commented 6 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

dustinhiatt-wf commented 6 years ago

+1

brianshannan-wf commented 6 years ago

+1

rsc commented 6 years ago

Thanks!