Workiva / go-datastructures

A collection of useful, performant, and threadsafe Go datastructures.
Apache License 2.0
7.66k stars 834 forks source link

RM-30330 Workiva-Build: Update Dockerfile to mirror smithy.yaml #196

Closed ci-push-wf closed 6 years ago

ci-push-wf commented 6 years ago

Overview

In order to improve build isolation, reduce costs, reduce support burden, remove black magic, and improve local consistency, we are migrating away from smithy.yaml and existing Smithy infrastructure to Dockerfile builds supported by off the shelf AWS resources.

Reviewing and merging this PR is the first step in that process; this PR simply copies the contents of your smithy.yaml into a more explicit Dockerfile. In order to begin running Dockerfile builds you will need to enable Dockerfile builds from your repo configuration page in Smithy. Once you have enabled Dockerfile builds for your repo, rebuilding the PR build in smithy will trigger the newly enabled Dockefile build.

Expectations

With only a couple of exceptions the behavior of this new Dockerfile should match the existing behavior in your smithy.yaml Therefore, our expectations are for you to merge this PR as soon as possible. If for any reason you discover a problem post merge, you can disable the new builds and re-enable smithy.yaml builds in your repo configuration page in Smithy

Support/Questions

The migration to Dockerfile builds is our top priority, so please reach out to us if you have any questions, comments, or concerns during this process. Non-urgent questions should go into Confluence Questions and urgent support can be requested in the Support: Build Tools Hipchat Room

More Info

Information about the migration to dockerfile can be found here A user guide for Dockerfile builds can be found here

@brianshannan-wf

aviary-wf commented 6 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

stefankraus-wf commented 6 years ago

LGTM 👀

brianshannan-wf commented 6 years ago

@dustinhiatt-wf @stevenosborne-wf

We should probably update this to use something smaller like alpine in the future

stefankraus-wf commented 6 years ago

There is also a section in our docs about reducing build duration that may help.

charliestrawn-wf commented 6 years ago

+1

brianshannan-wf commented 6 years ago

Good to know, I was just going for feature parity as I have a few of these to do and figured we could optimize later

kevinfrommelt-wf commented 6 years ago

+1