search

Workiva / goverge

A golang multi package coverage reporting tool.
Other
3 stars 8 forks source link

Go multi package coverage tool #1

Closed wesleybalvanz-wf closed 8 years ago

wesleybalvanz-wf commented 8 years ago

This is a tool to generate multi package go coverage this is the MVP version kind of things there are improvements that can be made and features that may still be needed but this is working to generate the full coverage.

@jacobmoss-wf @ericolson-wf @rosshendrickson-wf @alexandercampbell-wf @stevenosborne-wf

FYI: @jeffdoll-wf

alexandercampbell-wk commented 8 years ago

Looks like you added a LICENSE.txt file, but it's blank. Maybe that should have a Workiva copyright notice?

wesleybalvanz-wf commented 8 years ago

Possibly I only added the file because of line 33 of setup.py and I wasn't sure what needed to be in the file.

alexandercampbell-wk commented 8 years ago

Possibly I only added the file because of line 33 of setup.py and I wasn't sure what needed to be in the file.

Probably should add the Workiva copyright notice in LICENSE.

Copyright 2015 Workiva, LLC

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

 http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
wesleybalvanz-wf commented 8 years ago

@alexandercampbell-wf Done

wesleybalvanz-wf commented 8 years ago

@rosshendrickson-wf @alexandercampbell-wf I think all comments are addressed.

alexandercampbell-wk commented 8 years ago

+1

wesleybalvanz-wf commented 8 years ago

@alexandercampbell-wf I had to make a small adjustment because using ImportComment worked on cerberus and skaardb but doesn't on other projects because they don't have the import comment.

I changed it to import comment in the first place because just using go list was giving me a strange import path in smithy but clearly that's not going to work so I added a flag to just pass one in for the smithy case and this just uses go list now if no import path is passed in.

If you could review the last two commits that would be great.

alexandercampbell-wk commented 8 years ago

+1, lgtm

rosshendrickson-wf commented 8 years ago

+1 going to try and pip install this