Workiva / goverge

A golang multi package coverage reporting tool.
Other
3 stars 8 forks source link

Add threads and version flags #16

Closed wesleybalvanz-wf closed 8 years ago

wesleybalvanz-wf commented 8 years ago

This addresses https://github.com/Workiva/goverge/issues/15 and https://github.com/Workiva/goverge/issues/14

@markcampanelli-wf for https://github.com/Workiva/goverge/issues/14 just run with --threads=1 and it should run in basically "serial" mode.

Please review: @markcampanelli-wf @jacobmoss-wf @aldenpeterson-wf @seangerhardt-wf @matthinrichsen-wf

codecov-io commented 8 years ago

Current coverage is 89.66%

Merging #16 into master will increase coverage by +1.19% as of 98f3995

@@            master     #16   diff @@
======================================
  Files            7       7       
  Stmts          295     300     +5
  Branches        23      23       
  Methods          0       0       
======================================
+ Hit            261     269     +8
  Partial          4       4       
+ Missed          30      27     -3

Review entire Coverage Diff as of 98f3995

Powered by Codecov. Updated on successful CI builds.

jacobmoss-wf commented 8 years ago

+1

aldenpeterson-wf commented 8 years ago

+1. A few preexisting " instead of ' but otherwise minor.

wesleybalvanz-wf commented 8 years ago

@aldenpeterson-wf @jacobmoss-wf Had to fix a merge conflict should be good for a final review.

jacobmoss-wf commented 8 years ago

+1

aldenpeterson-wf commented 8 years ago

👍