Closed wesleybalvanz-wf closed 8 years ago
Number of Findings: 0
@@ master #27 diff @@
==========================================
Files 7 7
Lines 314 319 +5
Methods 0 0
Messages 0 0
Branches 25 27 +2
==========================================
+ Hits 283 288 +5
Misses 27 27
Partials 4 4
Powered by Codecov. Last update cd63290...fc24145
+1
+1 I agree with @aldenpeterson-wf, a comment could be used to improve the clarity of what is going on, but the performance gain is negligible. I'd favor readability.
@charliestrawn-wf I already made the change to refactor to be the way that Alden requested, github just doesn't hide the comment with the new approval process they have.
Yep, saw that. Just adding my 2 cents. Thanks for the ridiculously quick turnaround on this.
+1
+1
lgtm
This ignores the vendor folder when getting dependencies since we don't want to get the coverage for our dependencies just the repo under test.
@charliestrawn-wf @aldenpeterson-wf @seangerhardt-wf