search

Workiva / json_schema

dart implementation of json schema validator!
Other
37 stars 36 forks source link

export ValidationResults #192

Closed mx1up closed 2 months ago

mx1up commented 2 months ago

Ultimate problem:

ValidationResults can not be used outside package

How it was fixed:

export the class

fixes #175

aviary-wf commented 2 months ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

joecotton-wk commented 2 months ago

@mx1up Thanks for adding this! Would you do us a favor and revert 5.1.8 back to 5.1.7? That will allow our CI system to bump the version automatically. Once that's done, we'll get this one merged 👍

mx1up commented 2 months ago

@mx1up Thanks for adding this! Would you do us a favor and revert 5.1.8 back to 5.1.7? That will allow our CI system to bump the version automatically. Once that's done, we'll get this one merged 👍

sure, i reverted the commit bumping the version, which also reverts the changelog as I guess it's also no longer in use..

joecotton-wk commented 2 months ago

@mx1up Now format is failing 😔 Would you mind fixing? Thank you!

Once that's done (and barring no other problems), we'll get this merged for you.

joecotton-wk commented 2 months ago

@mx1up Come to think of it, I have no idea why format is failing 🤔 It's the same as it was before you reverted the version bump.

I also pulled down your branch and ran format on it, and it came back clean. So I'm confused why it's failing in CI.

Let me see if it's our CI at fault.

mx1up commented 2 months ago

@joecotton-wk were those checks run on the last 2 PRs? I don't see them in the PR activity log. My guess is:

that could explain it..

mx1up commented 2 months ago

either way, it needs to be fixed , so I updated the fork with latest master and reformatted the file

joecotton-wk commented 2 months ago

@Workiva/release-management-p