There were some missing areas of test coverage for some of the new APIs added in 5.x, as well as some issues discovered while improving test coverage in the corresponding React 16 branches of over_react.
Changes
Move export of createRef/forwardRef to react.dart instead of react_client.dart to avoid conflicting with over_react's exports of similarly-named functions. This change makes them consistent with other react-dart APIs replaced by over_react (findDomNode, Component, etc.)
Add missing test coverage for refs for JS components, fix conversion of Dart Ref objects
Fix forwardRef passing through a JsRef instead of a Ref to the consumer-provided function
Add ReactDartComponentVersion w/ constants and helpers around ReactClass.dartComponentVersion
Ref class boyscouting:
doc comment cleanup
update generic parameter to follow single-letter conventions, since the word "current" in that context if anything makes the parameter more confusing
kealjones-wk
commented
5 years ago
Motivation
There were some missing areas of test coverage for some of the new APIs added in 5.x, as well as some issues discovered while improving test coverage in the corresponding React 16 branches of over_react.
Changes
createRef/forwardReftoreact.dartinstead ofreact_client.dartto avoid conflicting with over_react's exports of similarly-named functions. This change makes them consistent with other react-dart APIs replaced by over_react (findDomNode, Component, etc.)RefobjectsforwardRefpassing through aJsRefinstead of aRefto the consumer-provided functionReactDartComponentVersionw/ constants and helpers aroundReactClass.dartComponentVersionRefclass boyscouting:Testing