Composition events - Githubissues

Workiva / react-dart

Dart Bindings for React JS

BSD 2-Clause "Simplified" License

413 stars 67 forks source link

Composition events #244

Closed theisensanders-wf closed 4 years ago

theisensanders-wf commented 4 years ago

Motivation

Add support for Composition events.

Changes

onCompositionStart, onCompositionUpdate, and onCompositionEnd event handlers.
Synthetic event type
Simulate test utils

Note: w3 spec events are compositionstart, compositionupdate, and compositionend (all lower-case), but react.js uses camel case for event names

Please Review @greglittlefield-wf @kealjones-wk @aaronlademann-wf @sydneyjodon-wk @joebingham-wk

theisensanders-wf commented 4 years ago

Turns out this doesn't solve my immediate issue since I'd be adding the listeners on dynamically added elements, not react elements. BUT, I do think this is still a good change to have since react.js supports these listeners even though dart2js does not.