Workiva / react-dart

Dart Bindings for React JS
BSD 2-Clause "Simplified" License
412 stars 67 forks source link

CPLAT-7226 Deprecate setClientConfiguration #253

Closed joebingham-wk closed 4 years ago

joebingham-wk commented 4 years ago

Motivation

setClientConfiguration is unnecessary and the default configuration can be initialized automatically.

Changes

Review

Please review @aaronlademann-wf @greglittlefield-wf @sydneyjodon-wk

semveraudit-wf commented 4 years ago

Public API Changes

Recommendation: :bangbang: Major version bump (fyi @Workiva/semver-audit-group )

@@ line 31: package:react/react_client/react_interop.dart @@
class React {}
+     void useImperativeHandle(JsRef ref, dynamic Function() createHandle, [List<dynamic> dependencies]);
//    Adding abstract members breaks all subclasses.
+ react/react_client/zone.dart

// Adding an entry point is a minor change.
@@ line 52: package:react/react_client/component_factory.dart @@
+  Map<dynamic, dynamic> unconvertJsProps(instance);
// Adding a top-level function is a minor change.
+ react/react_client/component_factory.dart

// Adding an entry point is a minor change.
@@ line 38: package:react/react_client/component_factory.dart @@
+  Function unconvertJsEventHandler(Function jsConvertedEventHandler);
// Adding a top-level function is a minor change.
Click to see 10 more API Changes

--- ```diff @@ line 476: package:react/hooks.dart @@ + void useImperativeHandle(Ref ref, dynamic Function() createHandle, [List dependencies]); // Adding a top-level function is a minor change. ``` ```diff @@ line 20: package:react/react_client/component_factory.dart @@ + dynamic listifyChildren(dynamic children); // Adding a top-level function is a minor change. ``` ```diff @@ line 87: package:react/react_client/component_factory.dart @@ + class JsBackedMapComponentFactoryMixin {} // Adding a class is a minor change. + ReactElement build(Map props, [List childrenArgs = const []]); // Adding a method is a minor change. + JsMap generateExtendedJsProps(Map props); // Adding a method is a minor change. + JsBackedMapComponentFactoryMixin(); // Adding a constructor is a minor change. From package:react/react.dart + dynamic get type; // Adding a field is a minor change. + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. ``` ```diff @@ line 264: package:react/react_client/component_factory.dart @@ + class ReactJsComponentFactoryProxy extends ReactComponentFactoryProxy {} // Adding a class is a minor change. + ReactJsComponentFactoryProxy(ReactClass jsClass, {this.shouldConvertDomProps: true, this.alwaysReturnChildrenAsList: false}); // Adding a constructor is a minor change. + Function get factory; // Adding a field is a minor change. + bool get alwaysReturnChildrenAsList; // Adding a field is a minor change. + bool get shouldConvertDomProps; // Adding a field is a minor change. + ReactElement build(Map props, [List childrenArgs]); // Adding a method is a minor change. From package:react/react.dart + ReactClass get type; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. ``` ```diff @@ line 304: package:react/react_client/component_factory.dart @@ + class ReactDomComponentFactoryProxy extends ReactComponentFactoryProxy {} // Adding a class is a minor change. + String get name; // Adding a field is a minor change. + void convertProps(Map props); // Adding a method is a minor change. + ReactElement build(Map props, [List childrenArgs = const []]); // Adding a method is a minor change. + ReactDomComponentFactoryProxy(name); // Adding a constructor is a minor change. + Function get factory; // Adding a field is a minor change. From package:react/react.dart + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. + String get type; // Adding a field is a minor change. ``` ```diff @@ line 214: package:react/react_client/component_factory.dart @@ + class ReactJsContextComponentFactoryProxy extends ReactJsComponentFactoryProxy {} // Adding a class is a minor change. + ReactElement build(Map props, [List childrenArgs]); // Adding a method is a minor change. + Function get factory; // Adding a field is a minor change. + bool get shouldConvertDomProps; // Adding a field is a minor change. + ReactJsContextComponentFactoryProxy(ReactClass jsClass, {this.shouldConvertDomProps: true, this.isConsumer: false, this.isProvider: false}); // Adding a constructor is a minor change. + ReactClass get type; // Adding a field is a minor change. + JsMap generateExtendedJsProps(Map props); // Adding a method is a minor change. + bool get alwaysReturnChildrenAsList; // Adding a field is a minor change. + bool get isConsumer; // Adding a field is a minor change. + bool get isProvider; // Adding a field is a minor change. From package:react/react.dart + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. ``` ```diff @@ line 100: package:react/react_client/component_factory.dart @@ + class ReactDartComponentFactoryProxy extends ReactComponentFactoryProxy {} // Adding a class is a minor change. + ReactElement build(Map props, [List childrenArgs = const []]); // Adding a method is a minor change. + Map get defaultProps; // Adding a field is a minor change. + ReactClass get reactClass; // Adding a field is a minor change. + InteropProps generateExtendedJsProps(Map props, dynamic children, {Map defaultProps}); // Adding a method is a minor change. + ReactDartComponentFactoryProxy(ReactClass reactClass); // Adding a constructor is a minor change. From package:react/react.dart + ReactClass get type; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. ``` ```diff @@ line 188: package:react/react_client/component_factory.dart @@ + class ReactDartComponentFactoryProxy2 extends ReactComponentFactoryProxy with JsBackedMapComponentFactoryMixin implements ReactDartComponentFactoryProxy {} // Adding a class is a minor change. + ReactClass get type; // Adding a field is a minor change. + ReactElement build(Map props, [List childrenArgs = const []]); // Adding a method is a minor change. + Map get defaultProps; // Adding a field is a minor change. + ReactClass get reactClass; // Adding a field is a minor change. + JsMap generateExtendedJsProps(Map props); // Adding a method is a minor change. + ReactDartComponentFactoryProxy2(ReactClass reactClass); // Adding a constructor is a minor change. From package:react/react.dart + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. ``` ```diff @@ line 340: package:react/react_client/component_factory.dart @@ + class ReactDartFunctionComponentFactoryProxy extends ReactComponentFactoryProxy with JsBackedMapComponentFactoryMixin {} // Adding a class is a minor change. + String get displayName; // Adding a field is a minor change. + ReactDartFunctionComponentFactoryProxy(DartFunctionComponent dartFunctionComponent, {String displayName}); // Adding a constructor is a minor change. + JsFunctionComponent get reactFunction; // Adding a field is a minor change. + ReactElement build(Map props, [List childrenArgs = const []]); // Adding a method is a minor change. From package:react/react.dart + ReactJsComponentFactory reactComponentFactory; // Adding a field is a minor change. + JsFunctionComponent get type; // Adding a field is a minor change. + dynamic call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified]); // Adding a method is a minor change. ``` ### Ignored changes - `@visibleForTesting` members: ```diff @@ line 20: package:react/react_client/zone.dart @@ + Zone componentZone = Zone.root; // Adding a top-level variable is a minor change. ``` ---

Showing results for bfd44cd917eb6e14a3e3c59401854c49a640ecf9

Powered by semver-audit-service. Please report any problems by filing an issue. Reported by the dart semver audit client 2.0.3 Browse public API.

Last edited UTC Feb 03 at 22:03:01

greglittlefield-wf commented 4 years ago

Major version bump indicated by semver bot is a false positive

QA +1