issues
search
Workiva
/
react-dart
Dart Bindings for React JS
BSD 2-Clause "Simplified" License
412
stars
67
forks
source link
Run function/forwardRef components in component zone, run children tests
#271
Closed
greglittlefield-wf
closed
4 years ago
greglittlefield-wf
commented
4 years ago
Motivation
Render logic for function and
forwardRef
components weren't being run in the component zone, which was inconsistent with class-based components.
Existing children tests that verify children are always
List
s in Dart weren't being run for function and
forwardRef
components
Solution
Add component zone logic and tests to
commonFactoryTests
Run
commonFactoryTests
for
forwardRef
components
Update children tests to run for function and
forwardRef
components
Testing
Tests pass
Revert changes in
https://github.com/cleandart/react-dart/pull/269
and verify that children tests fail
Motivation
forwardRef
components weren't being run in the component zone, which was inconsistent with class-based components.List
s in Dart weren't being run for function andforwardRef
componentsSolution
commonFactoryTests
commonFactoryTests
forforwardRef
componentsforwardRef
componentsTesting