Workiva / react-dart

Dart Bindings for React JS
BSD 2-Clause "Simplified" License
413 stars 67 forks source link

CPLAT-12688 Add synthetic Event Utils to master #282

Closed joebingham-wk closed 4 years ago

joebingham-wk commented 4 years ago

To prepare for React 17, there needs to be APIs that abstract the creation of SyntheticEvents so that we can remove dependence on the event class constructors.

Changes

QA

joebingham-wk commented 4 years ago

For CI, Dart 2.10.x fails on the formatting step - my understanding is that this was known and ignored for now. Let me know if there is something to do there though!

sydneyjodon-wk commented 4 years ago

QA+1 Everything looks great!

  • [x] Review that tests correctly test getting and setting
  • [x] Verify consumer examples of using the APIs work as expected (passing CI should be sufficient)
joebingham-wk commented 4 years ago

Verified CI failed due to that same Dart 2.10.x formatting step!