Closed greglittlefield-wf closed 3 years ago
QA +1
pbr test -- -P dartdevc
)pbr test -r -- -P dart2js
)console.warn
tests fail in DDC (pbr test -- -P dartdevc
) for only the "dev" suites (prod files should not be affected)w_context_menu
and w_input_validation
and verify that the error is only logged once
Motivation
As a workaround to https://github.com/dart-lang/sdk/issues/43939, our
SyntheticEvent
classes are non@anonymous
.A consequence of this is that, in the DDC, when event handlers are type-checked in certain situations, they emit console warnings every time.
These warnings can quickly become excessive when interacting with an app.
Solution
Boyscouting
Testing
pbr test -- -P dartdevc
)pbr test -r -- -P dart2js
)console.warn
tests fail in DDC (pbr test -- -P dartdevc
) for only the "dev" suites (prod files should not be affected)