Workiva / react-dart

Dart Bindings for React JS
BSD 2-Clause "Simplified" License
412 stars 67 forks source link

Fix isMouseEvent returning false for simulated context menu events #301

Closed greglittlefield-wf closed 3 years ago

greglittlefield-wf commented 3 years ago

Motivation

isMouseEvent was incorrectly returning false for events created via Simulate.contextMenu.

It looks like we were missing type-checking test coverage for contextmenu events (I checked to see if any more were missing, but contextmenu was the only one).

Solution

QA Instructions

aviary-wf commented 3 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

semveraudit-wf commented 3 years ago

Public API Changes

No changes to the public API found for commit f3f880f1ae1b3b3a3f0b397f4e9a39de7c0f2157

Showing results for f3f880f1ae1b3b3a3f0b397f4e9a39de7c0f2157

Powered by semver-audit-service. Please report any problems by filing an issue. Reported by the dart semver audit client 2.2.0 Browse public API.

Last edited UTC Jan 27 at 16:45:09

aaronlademann-wf commented 3 years ago

@aviary-wf try again please

greglittlefield-wf commented 3 years ago

@aviary-wf

greglittlefield-wf commented 3 years ago

@Workiva/release-management-p