Work around $identityHash being added to JS objects passed into jsifyAndAllowInterop

[greglittlefield-wf]

Ultimate Problem

In dart2js, passing a JS object into identityHashCode results in an $identityHash property being added to it: https://github.com/dart-lang/sdk/issues/47595.

This is undesirable since this property can get added to nested props maps of JS components.

Solution

• Replace usage of identityHashCode with _jsObjectFriendlyIdentityHashCode, which doesn't call identityHashCode for JS objects
• Add regression test
• Add other tests for jsifyAndAllowInterop, based on the Dart SDK's allowInterop tests

QA instructions

• CI passes
• (If desired) Change _convertedObjects back to Map.identity() and verify tests fail in dart2js:

  pub run build_runner test -r '--build-filter=test/react_client/js_interop_helpers_test**' -- test/react_client/js_interop_helpers_test.dart

[aviary-wf]

Security Insights

(3) Vulnerable direct dependencies were detected

1 vulns in ansi-regex < 5.0.1 via yarn.lock

1 vulns in glob-parent < 5.1.2 via yarn.lock

1 vulns in set-value < 4.0.1 via yarn.lock

Action Items

• Review dependencies for available updates
• See this Splunk dashboard for more CVE details
• Review PR for security impact; comment "security review required" if needed or unsure

• Verify aviary.yaml coverage of security relevant code

  Questions or Comments? Reach out on Slack: #support-infosec.

[aaronlademann-wf]

Testing out with https://github.com/Workiva/react_material_ui/pull/127 now...

[aaronlademann-wf]

+10

• [x] The failing test involving $identityHash seen here is no longer failing on a CI run that pulls in these changes

@Workiva/release-management-pp