Workiva / react-dart

Dart Bindings for React JS
BSD 2-Clause "Simplified" License
412 stars 67 forks source link

Narrow dependency_validator range to avoid NNBD issue #342

Closed sourcegraph-wk closed 2 years ago

sourcegraph-wk commented 2 years ago

We recently discovered that if a package resolves to dependency_validator >=3.0.0 and build_config <1.0.0, running the dependency_validator tool will fail during precompilation due to null safety.

We are merging a fix to dependency_validator, but unfortunately it won't prevent consumers from resolving to the v3.x versions that still have the issue. This PR addresses the issue for consumers by narrowing the range to no longer include dependency_validator v3.

Note: We originally widened this range as a part of the effort to upgrade our ecosystem to analyzer v1, but it is not strictly necessary. Consumers of dependency_validator v2 can still successfully resolve to analyzer v1.

For more info, reach out to #support-frontend-architecture on Slack.

_Created by Sourcegraph batch change Workiva/narrow_dependency_validator_range._

aviary-wf commented 2 years ago

Security Insights

(2) Vulnerable direct dependencies were detected
  • 1 vulns in ansi-regex < 4.1.1 via yarn.lock
  • 1 vulns in glob-parent < 5.1.2 via yarn.lock
  • Action Items

    kimlarson-wk commented 2 years ago

    QA+1

    kimlarson-wk commented 2 years ago

    @Workiva/release-management-pp ready for merge.