React 18.2.0 - Githubissues

Workiva / react-dart

Dart Bindings for React JS

BSD 2-Clause "Simplified" License

413 stars 67 forks source link

Open greglittlefield-wf opened 1 year ago

greglittlefield-wf commented 1 year ago

aviary3-wk commented 1 year ago

No security relevant content was detected by automated scans.

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

regenvanwalbeek-wf commented 9 months ago

@greglittlefield-wf We started getting react.js and react_dom.js must be loaded. errors because https://cdn-dev.wdesk.org/react-dart/5167194/react_with_react_dom_prod.js no longer exists -- it looks like we must have a 3 month expiry on cdn-dev assets?

I resolved the conflicts and pushed up a change. The tests fail but it successfully generated an asset. Hopefully this will fix our issue 🤞

edit This worked for us

greglittlefield-wf commented 9 months ago

@regenvanwalbeek-wf Sorry about that! 😬

Hmm to help prevent this issue from happening again, would it be possible to load from a local packages/react/... path rather than the dev CDN?

regenvanwalbeek-wf commented 9 months ago

That's how I was leaning as well - Once I have some free time I will give that a shot (hopefully by tomorrow)

greglittlefield-wf commented 9 months ago

@regenvanwalbeek-wf Sounds good, let me know if we can help with anything!

regenvanwalbeek-wf commented 8 months ago

(Forgot to mention, we ended up loading from local and it worked fine https://github.com/Workiva/esg_ui/pull/2765)