Workiva / react-dart

Dart Bindings for React JS
BSD 2-Clause "Simplified" License
412 stars 67 forks source link

FED-1881 Fix regression in SyntheticEvent mock class type-checking #381

Closed greglittlefield-wf closed 10 months ago

greglittlefield-wf commented 10 months ago

Motivation

When testing these changes, we ran into a case where a consumer was mocking type, and relying on type-checking utilities to respect that.

class MockSyntheticEvent extends Mock implements SyntheticEvent {}
final mockEvent = MockSyntheticEvent();
when(mockEvent.type).then('click');
print(mockEvent.isMouseEvent);

Previously, this would print true, but in v7_wip, it prints false.

Solution

Testing

aviary2-wf commented 10 months ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

robbecker-wf commented 10 months ago

QA+1 CI passes with updated/new tests that cover the functionality

greglittlefield-wf commented 10 months ago

@Workiva/release-management-p