Workiva / state_machine

Easily create a finite state machine and define legal state transitions. Listen to state entrances, departures, and transitions.
Other
61 stars 24 forks source link

Null Safety support? #61

Open nipunasudha opened 3 years ago

nipunasudha commented 3 years ago

Could you please update the package for flutter 2.0?

evanweible-wf commented 3 years ago

Hello, thanks for the issue! We've started working to migrate our OSS packages to NNBD, but there are a few dependencies that need to be migrated before this one. I'll update this issue when we get there!

nipunasudha commented 3 years ago

Thank you very much for your time!

nipunasudha commented 3 years ago

Any update on this?

nipunasudha commented 3 years ago

Could you please update us on the progress? Only 3 more packages to go for me! 😄😍

nipunasudha commented 3 years ago

Well this is sad, I created a local version of the state_machine by removing the Disposable dependency from w_common, and just using callbacks to listen to the machine instead of Streams. This is not ideal but works for me until this package is updated.

travissanderson-wf commented 3 years ago

with the latest release of w_common you can now use state_machine in Flutter, but not with null safety yet

travissanderson-wf commented 3 years ago

Is there any way you can make state_machine package independent from the Disposable utilities? May be by allowing users to manually call a Machine.dispose() method?

@nipunasudha what is the reason you'd like this done?

nipunasudha commented 3 years ago

Is there any way you can make state_machine package independent from the Disposable utilities? May be by allowing users to manually call a Machine.dispose() method?

@nipunasudha what is the reason you'd like this done?

Thank you for the response @travissanderson-wf . The suggestion was just based on the fact that w_common is not null safe yet. But I also think 3rd party core/low level mechanism packages such as state_machine should be self-contained whenever possible.

evanweible-wf commented 3 years ago

@nipunasudha I think that's a good point, so I'll create a separate issue for that. We will probably focus on just migrating to NNBD for the time being, though, just to make sure we can get all of our OSS package migrated with as little friction as possible.

buehler commented 3 years ago

@evanweible-wf, do you have a vague ETA for the NNBD? I'd really like to play around with it :-) Thanks for the package!

evanweible-wf commented 3 years ago

To be honest, I don't have a good ETA right now :( Internally, we're getting closer to a point where we'll be prioritizing getting all of our packages updated to the latest Dart, but until then it's just a couple of us in our spare time, and I'm unfortunately short on that right now. I'll keep this issue updated, though!

buehler commented 3 years ago

I know the feeling! :-)

Thanks for the update @evanweible-wf !

sebastianhaberey commented 3 years ago

Aww shame, I just saw that this plugin might be great for my use case but I definitely know the feeling as well 😄

appinteractive commented 3 years ago

Yeah I just found it but not being null safe is a dealbreaker for me 🙁

EnesKaraosman commented 2 years ago

Is there any update on null safety?

EnesKaraosman commented 1 year ago

Guys Flutter 4 is almost there. Pls upgrade to null safety :)