Update React and gulp-react

maxwellpeterson-wf commented 9 years ago

Problem

wGulp will fail to transpile JSX that uses any of the new JSX syntax featured in React 0.12

Solution

Update react and gulp-react dependency versions

Also in this PR

Change jshint rule to not require a new keyword before a capitalized function. Usually these capitalized variable names refer to classes that need to be instantiated with new. However, we have been using this syntax with React components and those should not use new - so we should disable this rule.

How to +10

I am unsure how backwards-compatible this change is. We should do some spot-checks on projects that are currently using React + wGulp and ensure there are no runtime errors when transpiled with this branch.

@trentgrover-wf @evanweible-wf

rmconsole-wf commented 9 years ago

    When this pull is merged I will not be able to function
    properly because no ticket is included in the title.

Last updated on Thursday, November 20 03:01 PM CST

trentgrover-wf commented 9 years ago

+10

smithy is happy
all examples still work as expected @charliekump-wf ready for QA+1 and merge

charliekump-wf commented 9 years ago

QA Resource Approval: +1

[x] Testing instruction
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
[x] Unit test created/updated
[x] All unit tests pass

Merging into master.

Workiva / wGulp