Closed robbecker-wf closed 9 years ago
When this pull is merged I will use the following information:
Version: wGulp 0.7.5
Release Ticket: CP-329
Last updated on Tuesday, January 13 01:22 PM CST
@maxwellpeterson-wf @evanweible-wf
CI failing through no change of mine. :(
That CI failure is wack. How does that relate to this change? Looks like it is failing on master.
+1
+1 - fixed the broken test fixture (just from differences in React 0.12.2)
@jayudey-wf @charliekump-wf ready for merge and minor patch release
+1
+1
+1
QA Resource Approval: +10
@charliekump-wf
+10
I differed from the instructions a bit, as this branch isn't in the npm registry. I just npm installed a local directory.
mkdir test cd test npm init cd .. cd wGulp git clone git@github.com:Workiva/wGulp.git cd wGulp gco more-init cd .. cd test npm install ../wGulp/ ./node_modules/.bin/gulp-init
src/ and test/ are there.
@rmconsole-wf
Merging.
I added to the gulp-init script so that it creates the src and test directories when run. If you follow the instructions to create a project from scratch and then run gulp, it immediately fails because there is no src directory.
We could consider moving some of the generator functionality into the gulp-init script.
To test:
It should create the test and src directory.