CP-367 Do not minify:js in dist by default

Workiva / wGulp

Opinionated Suite of Gulp Tasks for JavaScript and TypeScript projects.

Apache License 2.0

12 stars 9 forks source link

CP-367 Do not minify:js in dist by default #126

Closed maxwellpeterson-wf closed 9 years ago

maxwellpeterson-wf commented 9 years ago

Description

This change is to align with CP team's default library workflow. We will distribute unminified library files in dist/, and a minified globalBundle with sourcemaps in lib/ for Dart consumption. That minification is done by jspm itself during the bundling process.

Testing

install that branch of wGulp in some project and run gulp dist and make sure it doesn't run the minify:js task

@trentgrover-wf @evanweible-wf

rmconsole-wf commented 9 years ago

    When this pull is merged I will use the following information:
    Version: wGulp 0.7.7
    Release Ticket: CP-342

Last updated on Friday, January 23 09:43 AM CST

evanweible-wf commented 9 years ago

trentgrover-wf commented 9 years ago

+1 @jayudey-wf ready for merge

jayudey-wf commented 9 years ago

QA Resource Approval: +10

[x] Testing instruction
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- verified there were no minified js in the dist directory
[x] Unit test created/updated
[x] All unit tests pass

Merging into master.